[lldb] Add missing recursion when desugaring a type #10546
Merged
adrian-prantl merged 1 commit intoswiftlang:swift/release/6.2from Apr 28, 2025
Merged
[lldb] Add missing recursion when desugaring a type #10546adrian-prantl merged 1 commit intoswiftlang:swift/release/6.2from
adrian-prantl merged 1 commit intoswiftlang:swift/release/6.2from
Conversation
Author
|
@swift-ci test |
kastiglione
reviewed
Apr 24, 2025
lldb/test/API/lang/swift/clangimporter/objc_optional_dict/TestSwiftObjCOptionalDict.py
Outdated
Show resolved
Hide resolved
The type canonicalization would early-exit when desugaring of an outer node was successful, which means that GetCanonicalNode() would behave like DemangleCanonicalOutermostType() for types like sugared Optionals. rdar://149273756
adrian-prantl
force-pushed
the
149273756
branch
from
add2d29 to
c8807f7
Compare
Author
|
@swift-ci test |
JDevlieghere
approved these changes
Apr 25, 2025
augusto2112
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type canonicalization would early-exit when desugaring of an outer node was successful, which means that GetCanonicalNode() would behave like DemangleCanonicalOutermostType() for types like sugared Optionals.
rdar://149273756